fix(amazonq): file premissions are now preserved and mvn and gradle files are kept in the repo archives #5235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
reviewed
Jan 8, 2025
|
|
||
| createTemporaryZipFileAsync { zipOutput -> | ||
| val zipFilePath = createTemporaryZipFileAsync { zipfs -> | ||
| val isPosix = FileSystems.getDefault().supportedFileAttributeViews().contains("posix") |
Contributor
There was a problem hiding this comment.
nit: can we assign the string to a variable?
| val externalFilePath = Path(file.path) | ||
| val relativePath = Path(file.path).relativeTo(projectRootPath) | ||
| val zipfsPath = zipfs.getPath("/$relativePath") | ||
| runBlocking { |
Contributor
There was a problem hiding this comment.
it's on the background thread, but is it possible to run this without blocking the thread?
Contributor
|
/retryBuilds |
manodnyab
approved these changes
Jan 14, 2025
neilk-aws
approved these changes
Jan 14, 2025
Will-ShaoHua
approved these changes
Jan 14, 2025
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
…iles are kept in the repo archives (aws#5235) * fix(amazonq): archives now preserve file premissions and amazon q can edit nvm/gradle files * fix test failures on windows * change FS operations to use BG context --------- Co-authored-by: Hamed Soleimani <[email protected]> Co-authored-by: manodnyab <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
…iles are kept in the repo archives (aws#5235) * fix(amazonq): archives now preserve file premissions and amazon q can edit nvm/gradle files * fix test failures on windows * change FS operations to use BG context --------- Co-authored-by: Hamed Soleimani <[email protected]> Co-authored-by: manodnyab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve file permissions in the zip archive, fix bugs in gitignore matching and keep mvm and gradle files
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.